Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jupyter_server_config.json as config file in the update password api #390

Merged

Conversation

echarles
Copy link
Member

Use jupyter_server_config.json instead of jupyter_notebook_config.json as config file in the update password API.

@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #390 (5b45a03) into master (1b7f6fe) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
+ Coverage   69.25%   69.31%   +0.06%     
==========================================
  Files          56       56              
  Lines        6131     6131              
  Branches      798      798              
==========================================
+ Hits         4246     4250       +4     
+ Misses       1619     1617       -2     
+ Partials      266      264       -2     
Impacted Files Coverage Δ
jupyter_server/auth/login.py 69.76% <ø> (ø)
jupyter_server/services/kernels/handlers.py 58.51% <0.00%> (+0.26%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 81.49% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7f6fe...5b45a03. Read the comment docs.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@echarles echarles merged commit edf4a08 into jupyter-server:master Jan 19, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…yter_server_config

Use jupyter_server_config.json as config file in the update password api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants