Update manager.py: more descriptive warnings when extensions fail to load #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made warning message when an extension fails to load more descriptive to avoid puzzling the user about what is going on
Zsailer
approved these changes
Jan 29, 2021
kevin-bates
reviewed
Jan 29, 2021
There was a problem hiding this comment.
I agree with @Zsailer - this is very useful. So much so, I was hoping you could do the same for the link and add methods. 😄 🙏
Also, while we're in this file, would it be possible to make a quick pass to convert the log statements to use f-strings? Aside from those in these methods, there are just a couple other raise statements near the top that would require modification.
I think it would be good to start converting these when we can.
|
Since there hasn't been activity on this PR for a few weeks, I suggest we merge as-is and address @kevin-bates's suggestions in later PRs. |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Update manager.py: more descriptive warnings when extensions fail to load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning message are descriptive when an extension fails to load. To provide an example, before this tiny fix, I got the warning message when starting jupyter-lab:
[W 2021-01-29 16:36:12.766 ServerApp] 'nbextensions_path'while now I would get:
[W 2021-01-29 16:55:35.576 ServerApp] jupyter_nbextensions_configurator | extension failed loading with message: 'nbextensions_path'clarifying that it is
jupyter_nbextensions_configuratornot loading. With this better description, this warning is no more surprising because I know that this extension is for the classic notebook only.