Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Session.username default value change #398

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

mwakaba2
Copy link
Member

@mwakaba2 mwakaba2 commented Feb 1, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #398 (d5aa937) into master (6338d30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   68.85%   68.85%           
=======================================
  Files          57       57           
  Lines        6319     6319           
  Branches      846      846           
=======================================
  Hits         4351     4351           
  Misses       1678     1678           
  Partials      290      290           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6338d30...d5aa937. Read the comment docs.

Co-authored-by: Kevin Bates <kbates4@gmail.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kevin-bates kevin-bates merged commit 5013f62 into jupyter-server:master Feb 1, 2021
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants