Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case ExtensionApp that starts the ServerApp #401

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Special case ExtensionApp that starts the ServerApp #401

merged 1 commit into from
Feb 3, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Feb 3, 2021

This significantly simplifies how ExtensionApps initialize a ServerApp. ServerApp.initialize now has an optional argument, starter_extension, that special-cases the extension which started the server and loads server-specific config from that extension.

As a nice side effect, the default_url and open_browser traits are handled more cleanly.

@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #401 (6f9a43a) into master (5013f62) will increase coverage by 1.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   68.87%   69.93%   +1.06%     
==========================================
  Files          57       57              
  Lines        6319     6313       -6     
  Branches      846      846              
==========================================
+ Hits         4352     4415      +63     
+ Misses       1678     1596      -82     
- Partials      289      302      +13     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 64.74% <69.23%> (+4.65%) ⬆️
jupyter_server/extension/application.py 72.30% <73.68%> (+11.30%) ⬆️
jupyter_server/extension/manager.py 86.74% <80.00%> (-0.55%) ⬇️
jupyter_server/utils.py 63.46% <100.00%> (ø)
jupyter_server/base/handlers.py 68.24% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5013f62...6f9a43a. Read the comment docs.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Zsailer Zsailer merged commit 1ca52a8 into jupyter-server:master Feb 3, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Special case ExtensionApp that starts the ServerApp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants