Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct logging message position #410

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Correct logging message position #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions jupyter_server/extension/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,17 @@ def get_metadata(package_name, logger=None):
# _jupyter_server_extension_paths. We will remove in
# a later release of Jupyter Server.
try:
return module, module._jupyter_server_extension_paths()
except AttributeError:
extension_points = module._jupyter_server_extension_paths()
if logger:
logger.debug(
logger.warning(
"A `_jupyter_server_extension_points` function was not "
"found in {name}. Instead, a `_jupyter_server_extension_paths` "
"function was found and will be used for now. This function "
"name will be deprecated in future releases "
"of Jupyter Server.".format(name=package_name)
)
return module, extension_points
except AttributeError:
pass

# Dynamically create metadata if the package doesn't
Expand Down Expand Up @@ -92,4 +93,4 @@ def validate_extension(name):
If this works, nothing should happen.
"""
from .manager import ExtensionPackage
return ExtensionPackage(name=name)
return ExtensionPackage(name=name)