Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsoleted asyncio-patch fixture #412

Merged

Conversation

kevin-bates
Copy link
Member

With the minimum version bump to Tornado 6.1, we should no longer be using the patch in our fixtures. This update removes that fixture, as well as the update to the io_loop fixture needed to enable the patch.

@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #412 (0017061) into master (3220f4f) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   69.90%   69.84%   -0.07%     
==========================================
  Files          57       57              
  Lines        6320     6310      -10     
  Branches      847      847              
==========================================
- Hits         4418     4407      -11     
- Misses       1599     1600       +1     
  Partials      303      303              
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 91.62% <ø> (-0.45%) ⬇️
jupyter_server/serverapp.py 64.57% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3220f4f...0017061. Read the comment docs.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit b993b2d into jupyter-server:master Feb 11, 2021
@kevin-bates kevin-bates deleted the remove-asyncio-patch-fixture branch February 12, 2021 00:02
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…-patch-fixture

Remove obsoleted asyncio-patch fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants