Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing template for view.html #414

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Feb 15, 2021

and test coverage to exercise it

server has the view handler, but not the template it relies on.

view.html is copied from notebook 6.2

currently, any visit to /view/... will 500 due to this missing template.

and test coverage to exercise it
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks, @minrk

@Zsailer Zsailer merged commit 01f0f43 into jupyter-server:master Feb 15, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
…flow (jupyter-server#414)

* wip

* replace synchronizer with more relaxed cache system

* add reconnect flow

* simplify cache

* remove comments

* handle dead kernel more gracefully

* add migration method for kerneltable to kernel cache

* add helpful comment

* logging

* drop comment

* remove commented out code

* Bump to 0.22.0
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants