Solve UnboundLocalError in launch_browser() #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's scoping rules cause the log statement to fail because `_` was being redefined in `launch_browser()`.
blink1073
approved these changes
Feb 22, 2021
|
Thank you! |
|
Good catch @jamesmishra! |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Solve UnboundLocalError in launch_browser()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's scoping rules cause the log statement to fail because
_was being redefined inlaunch_browser().The issue was introduced in this commit and flagged by CI.
I can confirm that this bug causes JupyterLab to crash when it cannot find a web browser.