Port terminal culling from Notebook #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds functionality to track a terminal's last activity and optionally cull terminals that have been inactive for some specified duration.
RTD is currently failing with an ImportError Also move to a recent Python, because I don't know how long 3.5 will be available on conda.
* Restore detection of missing terminado package * Properly handle terminals_enabled config * Disambiguate terminado availability from web settings * Further clarity on terminal availability * Rename terminals_in_use back to terminals_available
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 77.63% 77.81% +0.17%
==========================================
Files 105 106 +1
Lines 8964 9086 +122
Branches 956 968 +12
==========================================
+ Hits 6959 7070 +111
- Misses 1666 1669 +3
- Partials 339 347 +8
Continue to review full report at Codecov.
|
Zsailer
reviewed
Mar 10, 2021
Zsailer
approved these changes
Mar 10, 2021
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…culling Port terminal culling from Notebook
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings from notebook the following PRs to enable the culling of terminals:
Resolves #432
(Note: I was seeing intermittent CI failures in CI-setup and post-test phases (install examples). All failures were related to python installation issues and it felt like a repository was down or some kind of update was occurring since the issue would move around. Since these shouldn't be related, I'm moving forward with submitting the PR.)