Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some of ipython_genutils no-op. #440

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Mar 8, 2021

ipython_genutils is complicated to package on some linux distro because
of nose, and in general not useful as it mostly offered python 2/3
compat layer.

Goal always has been to remove any usage of ipython_genutils

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Carreau - this looks good. I just had the one comment regarding the "duplicated" import.

jupyter_server/services/contents/filecheckpoints.py Outdated Show resolved Hide resolved
@blink1073 blink1073 added this to the 1.6 milestone Mar 23, 2021
@blink1073 blink1073 modified the milestones: 1.6, 1.7 Apr 1, 2021
ipython_genutils is complicated to package on some linux distro because
of nose, and in general not useful as it mostly offered python 2/3
compat layer.

Goal always has been to remove any usage of ipython_genutils
@codecov-commenter
Copy link

Codecov Report

Merging #440 (b4d3403) into master (15d3782) will increase coverage by 0.46%.
The diff coverage is 69.56%.

❗ Current head b4d3403 differs from pull request most recent head d2ae127. Consider uploading reports for the commit d2ae127 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   77.75%   78.21%   +0.46%     
==========================================
  Files         106      106              
  Lines        9269     9622     +353     
  Branches      997     1100     +103     
==========================================
+ Hits         7207     7526     +319     
- Misses       1706     1717      +11     
- Partials      356      379      +23     
Impacted Files Coverage Δ
jupyter_server/base/handlers.py 68.17% <0.00%> (+4.40%) ⬆️
jupyter_server/services/config/handlers.py 100.00% <ø> (ø)
jupyter_server/services/contents/fileio.py 75.26% <0.00%> (-0.13%) ⬇️
jupyter_server/services/contents/filemanager.py 66.88% <0.00%> (-0.08%) ⬇️
jupyter_server/services/contents/manager.py 88.28% <0.00%> (+0.49%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 81.02% <0.00%> (-0.14%) ⬇️
jupyter_server/serverapp.py 72.94% <66.66%> (+5.81%) ⬆️
...upyter_server/services/contents/filecheckpoints.py 63.15% <100.00%> (ø)
jupyter_server/services/sessions/sessionmanager.py 86.88% <100.00%> (-0.11%) ⬇️
jupyter_server/tests/nbconvert/test_handlers.py 28.12% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d3782...d2ae127. Read the comment docs.

@Carreau
Copy link
Contributor Author

Carreau commented Apr 24, 2021

rebased updated an pushed.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@blink1073 blink1073 merged commit 3cb4230 into jupyter-server:master Apr 24, 2021
@welcome
Copy link

welcome bot commented Apr 24, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Remove some of ipython_genutils no-op.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants