Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape user input in handlers flagged during code scans #449

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

kevin-bates
Copy link
Member

@kevin-bates kevin-bates commented Mar 18, 2021

This change runs user-input received as an argument on a few handlers through url_escape. These instances had been flagged by the code analysis CI.

Resolves #447

@codecov-io
Copy link

codecov-io commented Mar 18, 2021

Codecov Report

Merging #449 (8a03e48) into master (d690965) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   77.77%   77.81%   +0.04%     
==========================================
  Files         106      106              
  Lines        9089     9089              
  Branches      969      969              
==========================================
+ Hits         7069     7073       +4     
+ Misses       1671     1669       -2     
+ Partials      349      347       -2     
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 81.10% <0.00%> (+0.78%) ⬆️
jupyter_server/tests/services/kernels/test_api.py 99.01% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690965...8a03e48. Read the comment docs.

@blink1073 blink1073 added this to the 1.5 milestone Mar 18, 2021
@kevin-bates kevin-bates changed the title Escape user input in extension handlers examples Escape user input in handlers flagged during code scans Mar 18, 2021
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit d24f9f6 into jupyter-server:master Mar 18, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Escape user input in handlers flagged during code scans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent code scans are flagging an issue in extension example code
3 participants