Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for recursive symlink - (port Notebook 4670) #497

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

kevin-bates
Copy link
Member

This change also prevents permission-related exceptions from logging the file.

Resolves #495

This change also prevents permission-related exceptions from logging the file.

Co-authored-by: Shane Canon <scanon@gmail.com>
Co-authored-by: Thomas Kluyver <thomas@kluyver.me.uk>
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #497 (cb0d3aa) into master (ca5622a) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files         106      106           
  Lines        9256     9276   +20     
  Branches      996     1001    +5     
=======================================
+ Hits         7192     7208   +16     
- Misses       1707     1710    +3     
- Partials      357      358    +1     
Impacted Files Coverage Δ
jupyter_server/services/contents/filemanager.py 66.31% <50.00%> (-0.57%) ⬇️
...ter_server/tests/services/contents/test_manager.py 97.28% <100.00%> (+0.06%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 81.09% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca5622a...cb0d3aa. Read the comment docs.

@blink1073 blink1073 added this to the 1.7 milestone Apr 30, 2021
@blink1073 blink1073 added the bug label Apr 30, 2021
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit ad9ccb3 into jupyter-server:master Apr 30, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Fix for recursive symlink - (port Notebook 4670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlinks with inaccessible targets cause filemanager to not list anything in the same directory
3 participants