Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Packaging Dependency #515

Merged
merged 1 commit into from
May 10, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 10, 2021

Packaging should be a build time dependency only.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #515 (ef9f319) into master (0c63b2e) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   77.08%   77.06%   -0.02%     
==========================================
  Files         107      107              
  Lines        9495     9500       +5     
  Branches     1027     1029       +2     
==========================================
+ Hits         7319     7321       +2     
- Misses       1807     1808       +1     
- Partials      369      371       +2     
Impacted Files Coverage Δ
jupyter_server/_version.py 87.50% <85.71%> (-12.50%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 97.05% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c63b2e...ef9f319. Read the comment docs.

@blink1073 blink1073 added this to the 1.7 milestone May 10, 2021
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 454a66a into jupyter-server:master May 10, 2021
@jtpio jtpio deleted the remove-packaging-dep branch May 10, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants