init_httpserver at the end of initialize #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
init_httpserver references IOLoop.current() If a server extension sets an asyncio EventLoopPolicy, any prior reference to IOLoop.current or asyncio.get_event_loop() will be invalidated. We should try to avoid this during intialize at all, or at least until the very end. Arguably, the http server listen should occur in `.start()`
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 107 107
Lines 9500 9500
Branches 1029 1029
=======================================
Hits 7323 7323
Misses 1807 1807
Partials 370 370
Continue to review full report at Codecov.
|
This was referenced May 13, 2021
Zsailer
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init_httpserver references IOLoop.current()
If a server extension sets an asyncio EventLoopPolicy, any prior reference to IOLoop.current or asyncio.get_event_loop() will be invalidated.
We should try to avoid this during intialize at all, or at least until the very end.
Arguably, the http server listen should occur in
.start()There is one other reference to the loop in terminado: jupyter/terminado#102