Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jp_ws_fetch not work by its own #441 #527

Merged
merged 1 commit into from
May 26, 2021
Merged

fix jp_ws_fetch not work by its own #441 #527

merged 1 commit into from
May 26, 2021

Conversation

eastonsuo
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented May 26, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@40c477b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #527   +/-   ##
=========================================
  Coverage          ?   76.29%           
=========================================
  Files             ?      110           
  Lines             ?     9809           
  Branches          ?     1067           
=========================================
  Hits              ?     7484           
  Misses            ?     1944           
  Partials          ?      381           
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 90.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c477b...60e8d37. Read the comment docs.

@blink1073 blink1073 merged commit fd19cdc into jupyter-server:master May 26, 2021
@welcome
Copy link

welcome bot commented May 26, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073 blink1073 added this to the 1.9 milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants