Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild package-lock, fixing local setup #548

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

martinRenou
Copy link
Contributor

Bootstrap was fetched from localhost:5559 in the lock file, instead of from the official npm registry

Bootstrap was fetch from localhost:5559 in the lock file, instead of
from the official npm registry
},
"bootstrap": {
"version": "3.4.1",
"resolved": "http://localhost:5559/bootstrap/-/bootstrap-3.4.1.tgz",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the culprit, leading to the following error when running pip install -e .

npm ERR! FetchError: request to http://localhost:5559/bootstrap/-/bootstrap-3.4.1.tgz failed

@codecov-commenter
Copy link

Codecov Report

Merging #548 (7656e22) into master (2595716) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
- Coverage   76.32%   76.11%   -0.21%     
==========================================
  Files         110      110              
  Lines        9819     9817       -2     
  Branches     1067     1067              
==========================================
- Hits         7494     7472      -22     
- Misses       1944     1974      +30     
+ Partials      381      371      -10     
Impacted Files Coverage Δ
jupyter_server/traittypes.py 47.02% <0.00%> (-8.34%) ⬇️
jupyter_server/tests/extension/test_launch.py 93.84% <0.00%> (-1.61%) ⬇️
jupyter_server/services/contents/filemanager.py 65.48% <0.00%> (-0.84%) ⬇️
jupyter_server/services/contents/fileio.py 74.73% <0.00%> (-0.53%) ⬇️
jupyter_server/serverapp.py 64.76% <0.00%> (-0.20%) ⬇️
jupyter_server/tests/test_terminal.py 98.79% <0.00%> (-0.02%) ⬇️
jupyter_server/base/handlers.py 63.91% <0.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 80.07% <0.00%> (ø)
jupyter_server/tests/services/kernels/test_api.py 99.01% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2595716...7656e22. Read the comment docs.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 1.9 milestone Jul 2, 2021
@blink1073 blink1073 added the bug label Jul 2, 2021
@blink1073 blink1073 merged commit 6f970c5 into jupyter-server:master Jul 2, 2021
@welcome
Copy link

welcome bot commented Jul 2, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants