Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against unset spec #556

Merged
merged 4 commits into from
Jul 23, 2021
Merged

Conversation

fcollonval
Copy link
Member

Fixes #555

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #556 (269e3c5) into master (b4b1517) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   76.98%   76.90%   -0.08%     
==========================================
  Files         109      109              
  Lines        9945     9948       +3     
  Branches     1078     1078              
==========================================
- Hits         7656     7651       -5     
- Misses       1909     1914       +5     
- Partials      380      383       +3     
Impacted Files Coverage Δ
jupyter_server/tests/test_utils.py 100.00% <100.00%> (ø)
jupyter_server/utils.py 65.06% <100.00%> (+0.64%) ⬆️
jupyter_server/services/kernels/handlers.py 61.37% <0.00%> (-1.59%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 80.14% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b1517...269e3c5. Read the comment docs.

@blink1073 blink1073 added the bug label Jul 23, 2021
@blink1073 blink1073 added this to the 1.10 milestone Jul 23, 2021
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 42a1956 into jupyter-server:master Jul 23, 2021
@blink1073
Copy link
Collaborator

Cutting a patch release now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.10.0 is breaking JupyterLab CI
3 participants