Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make command line aliases work again #564

Merged

Conversation

mariobuikhuizen
Copy link
Contributor

This was broken by an unintentionally removed line in 0d11ffc.

Fixes #550

This was broken by an unintentionally removed line in 0d11ffc.

Fixes jupyter-server#550
@welcome
Copy link

welcome bot commented Aug 2, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #564 (062ed6b) into master (52e9467) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   76.93%   76.97%   +0.04%     
==========================================
  Files         109      109              
  Lines        9948     9949       +1     
  Branches     1078     1078              
==========================================
+ Hits         7653     7658       +5     
+ Misses       1913     1910       -3     
+ Partials      382      381       -1     
Impacted Files Coverage Δ
jupyter_server/extension/application.py 71.90% <100.00%> (+0.13%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 80.14% <0.00%> (-0.73%) ⬇️
jupyter_server/services/kernels/handlers.py 62.96% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e9467...062ed6b. Read the comment docs.

@Zsailer
Copy link
Member

Zsailer commented Aug 2, 2021

Thanks, @mariobuikhuizen!

@Zsailer Zsailer merged commit 2d43c93 into jupyter-server:master Aug 2, 2021
@welcome
Copy link

welcome bot commented Aug 2, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting extra traitlets of a LabServerApp sub class via the command line doesn't work since v1.6.4.
3 participants