Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pre-Commit Config #575

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Conversation

fcollonval
Copy link
Member

Adds support for pre-commit following the example from jupyter_client.

Adds support for [`pre-commit`](https://pre-commit.com/) following the example from [`jupyter_client`](jupyter/jupyter_client#631).
@fcollonval fcollonval marked this pull request as ready for review August 20, 2021 11:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #575 (278844a) into master (1444737) will increase coverage by 0.18%.
The diff coverage is 82.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   76.93%   77.12%   +0.18%     
==========================================
  Files         109      109              
  Lines        9951    10115     +164     
  Branches     1079     1089      +10     
==========================================
+ Hits         7656     7801     +145     
- Misses       1912     1929      +17     
- Partials      383      385       +2     
Impacted Files Coverage Δ
jupyter_server/auth/logout.py 44.44% <0.00%> (ø)
jupyter_server/prometheus/log_functions.py 100.00% <ø> (ø)
jupyter_server/serverapp.py 65.53% <ø> (-0.38%) ⬇️
..._server/tests/extension/mockextensions/__init__.py 100.00% <ø> (ø)
...ter_server/tests/extension/mockextensions/mock3.py 100.00% <ø> (ø)
jupyter_server/tests/test_version.py 100.00% <ø> (ø)
jupyter_server/tests/test_view.py 96.96% <ø> (ø)
jupyter_server/tests/unix_sockets/conftest.py 94.44% <ø> (ø)
jupyter_server/tests/unix_sockets/test_api.py 96.96% <ø> (-0.33%) ⬇️
...r/tests/unix_sockets/test_serverapp_integration.py 21.83% <ø> (-0.89%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1444737...278844a. Read the comment docs.

@blink1073 blink1073 added this to the 1.10 milestone Aug 20, 2021
@blink1073
Copy link
Collaborator

Let's merge this, and then rebase #571 which has relevant fixes for CI.

Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 90f619c into jupyter-server:master Aug 20, 2021
@fcollonval fcollonval deleted the ft/pre-commit branch August 20, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants