Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest: package conftest #576

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

oliver-sanders
Copy link
Contributor

closes #563

  • Package the conftest file.
  • This changes the test command to pytest jupyter_server.
  • Import the jupyter_server.conftest in the examples to inherit the plugin.

closes jupyter-server#563

* Package the conftest file.
* This changes the test command to `pytest jupyter_server`.
* Import the `jupyter_server.conftest` in the examples to inherit the
  plugin.
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #576 (b6c2fb2) into master (e3a146e) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   77.34%   77.69%   +0.35%     
==========================================
  Files         109      110       +1     
  Lines       10137    10234      +97     
  Branches     1093     1111      +18     
==========================================
+ Hits         7840     7951     +111     
+ Misses       1908     1896      -12     
+ Partials      389      387       -2     
Impacted Files Coverage Δ
jupyter_server/conftest.py 76.92% <ø> (ø)
jupyter_server/tests/services/kernels/test_api.py 96.93% <0.00%> (-2.05%) ⬇️
jupyter_server/tests/extension/test_manager.py 100.00% <0.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 82.87% <0.00%> (+1.02%) ⬆️
jupyter_server/terminal/terminalmanager.py 87.50% <0.00%> (+1.25%) ⬆️
jupyter_server/extension/application.py 74.31% <0.00%> (+1.37%) ⬆️
jupyter_server/services/kernels/handlers.py 63.35% <0.00%> (+1.57%) ⬆️
...pyter_server/tests/extension/mockextensions/app.py 93.93% <0.00%> (+3.03%) ⬆️
jupyter_server/extension/manager.py 93.44% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a146e...b6c2fb2. Read the comment docs.

@oliver-sanders
Copy link
Contributor Author

  • Windows tests failing as expected.
  • MacOS PyPy tests failing at the installation phase trying to build pyzmq.

@blink1073
Copy link
Collaborator

Bumping to pick up the CI fixes from #571

@blink1073 blink1073 closed this Aug 24, 2021
@blink1073 blink1073 reopened this Aug 24, 2021
@blink1073 blink1073 added the bug label Aug 24, 2021
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 added this to the 1.10 milestone Aug 24, 2021
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @oliver-sanders. 👍

@Zsailer Zsailer merged commit 49d5772 into jupyter-server:master Aug 24, 2021
@blink1073 blink1073 modified the milestones: 1.10, 1.11 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run tests when installed from PyPI
4 participants