Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest_plugin: allow user specified headers in jp_ws_fetch #580

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

oliver-sanders
Copy link
Contributor

Fixes a small error in the jp_ws_fetch fixture where the headers provided to client_fetch were ignored in requests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #580 (7c41332) into master (49d5772) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 7c41332 differs from pull request most recent head a88e36f. Consider uploading reports for the commit a88e36f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   77.46%   77.52%   +0.05%     
==========================================
  Files         110      110              
  Lines       10184    10184              
  Branches     1100     1100              
==========================================
+ Hits         7889     7895       +6     
+ Misses       1907     1899       -8     
- Partials      388      390       +2     
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 90.81% <100.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 81.84% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d5772...a88e36f. Read the comment docs.

@blink1073 blink1073 added this to the 1.11 milestone Sep 9, 2021
@blink1073 blink1073 added bug and removed enhancement labels Sep 9, 2021
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 7574898 into jupyter-server:master Sep 9, 2021
@oliver-sanders oliver-sanders deleted the jp_ws_fetch_fix branch September 9, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants