Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: allow None for min_open_files_limit trait #587

Merged
merged 2 commits into from Oct 4, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Oct 4, 2021

The default value for this min_open_files_limit is None on Windows, but this trait doesn't (currently) allow None. This was causing issues in nbclassic unit tests, jupyter/nbclassic#63

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #587 (5d10ca4) into master (ac93dd8) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 5d10ca4 differs from pull request most recent head 9b6a7e2. Consider uploading reports for the commit 9b6a7e2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   77.47%   77.32%   -0.16%     
==========================================
  Files         110      110              
  Lines       10212    10212              
  Branches     1104     1252     +148     
==========================================
- Hits         7912     7896      -16     
- Misses       1910     1923      +13     
- Partials      390      393       +3     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.44% <ø> (ø)
...yter_server/tests/services/kernelspecs/test_api.py 96.55% <0.00%> (-3.45%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 79.79% <0.00%> (-2.06%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 96.93% <0.00%> (-2.05%) ⬇️
jupyter_server/services/kernels/handlers.py 60.92% <0.00%> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac93dd8...9b6a7e2. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Zsailer. (I didn't try this on a Windows machine but trust traitlets are working as expected.)

@Zsailer Zsailer merged commit f4c3889 into jupyter-server:master Oct 4, 2021
@Zsailer
Copy link
Member Author

Zsailer commented Oct 4, 2021

Thanks, @kevin-bates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants