Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \s deprecation warning #600

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Fix \s deprecation warning #600

merged 1 commit into from
Nov 1, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Nov 1, 2021

Fixes #591

@codecov-commenter
Copy link

Codecov Report

Merging #600 (aea4ae7) into master (8b9a3f7) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head aea4ae7 differs from pull request most recent head b152441. Consider uploading reports for the commit b152441 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   77.33%   77.40%   +0.06%     
==========================================
  Files         110      110              
  Lines       10251    10250       -1     
  Branches     1258     1257       -1     
==========================================
+ Hits         7928     7934       +6     
+ Misses       1921     1918       -3     
+ Partials      402      398       -4     
Impacted Files Coverage Δ
jupyter_server/auth/login.py 68.93% <100.00%> (ø)
...upyter_server/tests/services/nbconvert/test_api.py 100.00% <0.00%> (ø)
jupyter_server/serverapp.py 65.53% <0.00%> (+0.18%) ⬆️
...ter_server/tests/services/contents/test_manager.py 96.95% <0.00%> (+0.23%) ⬆️
jupyter_server/services/contents/filemanager.py 70.55% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9a3f7...b152441. Read the comment docs.

@Zsailer Zsailer merged commit fda4cc5 into jupyter-server:master Nov 1, 2021
@Zsailer Zsailer added the bug label Nov 1, 2021
@Zsailer Zsailer deleted the 591 branch January 16, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix \s deprecation warning
2 participants