Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up version info handling #620

Merged
merged 4 commits into from
Nov 28, 2021
Merged

Conversation

blink1073
Copy link
Collaborator

No description provided.

@blink1073 blink1073 added this to the 1.11 milestone Nov 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2021

Codecov Report

Merging #620 (0308229) into master (3b72d9c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   77.56%   77.63%   +0.06%     
==========================================
  Files         110      110              
  Lines       10404    10398       -6     
  Branches     1288     1408     +120     
==========================================
+ Hits         8070     8072       +2     
+ Misses       1934     1929       -5     
+ Partials      400      397       -3     
Impacted Files Coverage Δ
jupyter_server/_version.py 100.00% <100.00%> (+25.00%) ⬆️
jupyter_server/services/kernels/handlers.py 62.40% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b72d9c...0308229. Read the comment docs.

@blink1073 blink1073 merged commit e5cb6c4 into jupyter-server:master Nov 28, 2021
@blink1073 blink1073 deleted the use-fields branch November 28, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants