Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up downstream tests #629

Merged
merged 5 commits into from Dec 6, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 20 additions & 17 deletions .github/workflows/downstream.yml
Expand Up @@ -15,24 +15,29 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Set up Python 3.8
uses: actions/setup-python@v2
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Test jupyterlab_server
uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
with:
python-version: 3.8
package_name: jupyterlab_server

- name: Install dependencies
run: |
pip install --upgrade pip
pip install "."
pip install --pre --upgrade jupyterlab_server[test] jupyterlab[test] nbclassic[test]
pip freeze
- name: Run tests
working-directory: ../
- name: Test jupyterlab
uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
with:
package_name: jupyterlab
test_command: "python -m jupyterlab.browser_check --no-browser-test"

- name: Test nbclassic
uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
with:
package_name: nbclassic

- name: Test run nbclassic
run: |
# NOTE: tests won't pass from inside the working copy because of
# conftest.py:pytest_plugins (must be at the top level)
pytest --pyargs jupyterlab_server
python -m jupyterlab.browser_check --no-browser-test
pip install nbclassic
pip install --force-reinstall "."

# Make sure we can start and kill the nbclassic server
jupyter nbclassic --no-browser &
Expand All @@ -42,5 +47,3 @@ jobs:
sleep 5
kill $TASK_PID
wait $TASK_PID
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1