Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: clarify build system version #634

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

adamjstewart
Copy link
Contributor

@welcome
Copy link

welcome bot commented Dec 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #634 (b50327c) into master (82cd791) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   77.77%   77.73%   -0.04%     
==========================================
  Files         110      110              
  Lines       10444    10444              
  Branches     1415     1415              
==========================================
- Hits         8123     8119       -4     
- Misses       1921     1924       +3     
- Partials      400      401       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 60.40% <0.00%> (-1.53%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 97.60% <0.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82cd791...b50327c. Read the comment docs.

@vidartf
Copy link
Member

vidartf commented Dec 9, 2021

It wasn't immediately clear to me if ~=0.9 translated to (A) >=0.9, ==0.9.* or (B) >=0.9, ==0.*, but it turns out (B) is the behavior 👍

@@ -1,5 +1,5 @@
[build-system]
requires = ["jupyter_packaging~=0.9,<2"]
requires = ["jupyter_packaging~=0.9"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this to be >=0.10,<2 since we are compatible with the planned 1.0 interface for Jupyter-packaging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that if you want, just didn't want to change the current behaviour without a jupyter expert to tell me to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean this is no longer compatible with 0.9?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, this just sets a minimum on what will be used in the build environment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm comfortable with changing the upper bound since 1.X hasn't been released yet anyway, but I'm not sure if I'm comfortable with changing the lower bound. If this currently builds with 0.9, I see no reason to increase the lower bound.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. 😄

@adamjstewart
Copy link
Contributor Author

@vidartf is this ready to merge or would you like to see any of the additional changes recommended by @blink1073?

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@blink1073 blink1073 merged commit 6ff80c5 into jupyter-server:main Dec 22, 2021
@welcome
Copy link

welcome bot commented Dec 22, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@adamjstewart adamjstewart deleted the fixes/pyproject.toml branch December 22, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants