Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle KeyError when get session #641

Merged
merged 2 commits into from
Dec 14, 2021
Merged

handle KeyError when get session #641

merged 2 commits into from
Dec 14, 2021

Conversation

ccw630
Copy link
Contributor

@ccw630 ccw630 commented Dec 14, 2021

@welcome
Copy link

welcome bot commented Dec 14, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #641 (f27255b) into main (606487a) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   77.78%   77.69%   -0.09%     
==========================================
  Files         110      110              
  Lines       10462    10465       +3     
  Branches     1419     1419              
==========================================
- Hits         8138     8131       -7     
- Misses       1923     1934      +11     
+ Partials      401      400       -1     
Impacted Files Coverage Δ
jupyter_server/services/sessions/sessionmanager.py 87.50% <100.00%> (+0.26%) ⬆️
...ter_server/tests/services/sessions/test_manager.py 100.00% <100.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 81.26% <0.00%> (-1.91%) ⬇️
jupyter_server/services/kernels/handlers.py 61.25% <0.00%> (-1.46%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 97.60% <0.00%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606487a...f27255b. Read the comment docs.

@blink1073 blink1073 added the bug label Dec 14, 2021
@blink1073 blink1073 added this to the 1.13 milestone Dec 14, 2021
by blink1073

["", "pre-commit run --all-files"]
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The CI failures are unrelated.

@blink1073 blink1073 merged commit 4d2f85a into jupyter-server:main Dec 14, 2021
@welcome
Copy link

welcome bot commented Dec 14, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants