Clean up deprecations #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 77.79% 77.96% +0.16%
==========================================
Files 110 110
Lines 10465 10405 -60
Branches 1419 1400 -19
==========================================
- Hits 8141 8112 -29
+ Misses 1923 1906 -17
+ Partials 401 387 -14
Continue to review full report at Codecov.
|
Zsailer
reviewed
Dec 31, 2021
| @@ -232,7 +232,7 @@ def _headers_default(self): | |||
| default_value=None, | |||
| allow_none=True, | |||
| config=True, | |||
| help="""The authorization token used in the HTTP headers. The header will be formatted as: | |||
| help="""The authorization token used in the HTTP headers. The header will be formatted as:: | |||
There was a problem hiding this comment.
As this extra colon added on purpose?
There was a problem hiding this comment.
Yes, this docstring is copied directly into an RST file, and was causing warnings without the extra colon.
Zsailer
approved these changes
Dec 31, 2021
There was a problem hiding this comment.
Thanks, @blink1073. One nitpicky comment, but otherwise looks good.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627
Fixes #644
Drops Python 3.6, which is EOL
This requires a minor version release.