Print IPv6 url as hostname or enclosed in brackets #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Display hostname instead of :: * Enclose literal IPv6 addresses in square brackets, e.g. [::1], to separate from port number
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
Congrats on your first merged pull request in this project! 🎉 |
| ip = "%s" % socket.gethostname() | ||
| else: | ||
| ip = self.ip | ||
| ip = "[{}]".format(self.ip) if ":" in self.ip else self.ip |
There was a problem hiding this comment.
Suggested change
| ip = "[{}]".format(self.ip) if ":" in self.ip else self.ip | |
| ip = f"[{self.ip}]" if ":" in self.ip else self.ip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the display of IPv6 URLs:
Just like
0.0.0.0,::is replaced with the hostname.Literal IPv6 addresses are enclosed in square brackets, e.g.
::1is turned into[::1], to separate the address from the port number.