Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up full install test #689

Merged
merged 16 commits into from
Feb 3, 2022
Merged

Conversation

blink1073
Copy link
Collaborator

Partial solution for #677

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #689 (38c90df) into main (691d9f2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   77.80%   77.79%   -0.01%     
==========================================
  Files         110      110              
  Lines       10465    10465              
  Branches     1405     1405              
==========================================
- Hits         8142     8141       -1     
- Misses       1930     1931       +1     
  Partials      393      393              
Impacted Files Coverage Δ
jupyter_server/services/contents/fileio.py 75.00% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691d9f2...38c90df. Read the comment docs.

@blink1073
Copy link
Collaborator Author

Ha, well that was easy. 😅

@blink1073
Copy link
Collaborator Author

Cool, so the timeout traceback shows us that it is trying to destroy a zmq context unsuccessfully:

   File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/jupyter_client/multikernelmanager.py", line 116, in __del__
    self.context.destroy()
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/zmq/sugar/context.py", line 243, in destroy
    self.term()
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/zmq/sugar/context.py", line 190, in term
    return super(Context, self).term()

In jupyter_server/tests/services/sessions/test_api.py::test_modify_kernel_id[jp_server_config2].

@blink1073
Copy link
Collaborator Author

The latest sdist test is timing out with:

   File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/jupyter_client/multikernelmanager.py", line 116, in __del__
    self.context.destroy()
  File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/zmq/sugar/context.py", line 243, in destroy
    self.term()
  File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/zmq/sugar/context.py", line 190, in term
    return super(Context, self).term()

+++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++
tests/services/kernels/test_api.py::test_kernel_handler[jp_server_config2]

It is also failing:

 tests/test_terminal.py::test_terminal_create_with_cwd <- ../../../../../opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/jupyter_server/tests/test_terminal.py FAILED

@blink1073
Copy link
Collaborator Author

Let's merge this and leave #677 open, I'll move the comments there.

@blink1073 blink1073 merged commit 3a5f4b1 into jupyter-server:main Feb 3, 2022
@blink1073 blink1073 deleted the test-sdist branch February 3, 2022 20:12
@blink1073 blink1073 mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants