Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up handling of tests #700

Merged
merged 14 commits into from
Mar 1, 2022
Merged

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Feb 17, 2022

PyTest recommends putting your tests at the top level, and in fact we are having trouble in running our tests from the installed package in CI.

  • Move the tests folder to the top level
  • Include the tests folder in the sdist but not the wheel
  • In CI, unpack the sdist and run pytest from the sdist

Left to do:

  • Get all tests passing
  • Update the conda recipe to actually run the tests in the tests directory (needs a new release)
  • Update docs

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #700 (cd8656f) into main (745f5ba) will decrease coverage by 7.01%.
The diff coverage is n/a.

❗ Current head cd8656f differs from pull request most recent head b989c28. Consider uploading reports for the commit b989c28 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   77.97%   70.95%   -7.02%     
==========================================
  Files         115       62      -53     
  Lines       10817     7486    -3331     
  Branches     1465     1185     -280     
==========================================
- Hits         8435     5312    -3123     
+ Misses       1981     1817     -164     
+ Partials      401      357      -44     
Impacted Files Coverage Δ
tests/auth/test_authorizer.py
tests/auth/test_login.py
tests/auth/test_security.py
tests/auth/test_utils.py
tests/conftest.py
tests/extension/mockextensions/__init__.py
tests/extension/mockextensions/app.py
tests/extension/mockextensions/mock1.py
tests/extension/mockextensions/mock2.py
tests/extension/mockextensions/mock3.py
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745f5ba...b989c28. Read the comment docs.

@blink1073 blink1073 marked this pull request as ready for review February 17, 2022 22:34
@blink1073 blink1073 merged commit 84d569b into jupyter-server:main Mar 1, 2022
@blink1073 blink1073 deleted the cleanup-dist branch March 1, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants