Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Dependency Handling #707

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

blink1073
Copy link
Collaborator

Fixes #699

@blink1073
Copy link
Collaborator Author

It looks like we need to do this at the jupyter_client level first to catch the errors there that we're inheriting relating to task awaits and file descriptors left open.

@blink1073
Copy link
Collaborator Author

I'll open a new issue for filterwarnings so we can get the rest of the fixes in.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #707 (9907355) into main (eccdfa6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          62       62           
  Lines        7490     7490           
  Branches     1187     1187           
=======================================
  Hits         5312     5312           
  Misses       1821     1821           
  Partials      357      357           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eccdfa6...9907355. Read the comment docs.

@blink1073 blink1073 marked this pull request as ready for review March 3, 2022 11:20
@blink1073 blink1073 merged commit 55d9f68 into jupyter-server:main Mar 3, 2022
@blink1073 blink1073 deleted the test-cleanup branch March 3, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Handling
2 participants