Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use ServerApp.config_file_paths for consistency #715

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Re-use ServerApp.config_file_paths for consistency #715

merged 2 commits into from
Mar 10, 2022

Commits on Mar 10, 2022

  1. Use app.config_file_path to find server extensions 

    This property in the base class already has the same logic to add config_dir to jupyter_config_path

JupyterHub overrides this to have slightly different logic, and the same should apply here
    @minrk
    minrk committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    c19aad8 View commit details
    Browse the repository at this point in the history

  2. extensions should inherit parent's config_file_path 

    base ServerApp should have total control over config file loading
    @minrk
    minrk committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    e5265c3 View commit details
    Browse the repository at this point in the history