Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call pre_save_hook only on first chunk of large files #716

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

davidbrochart
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #716 (e6ca20f) into main (426a4c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files          62       62           
  Lines        7490     7491    +1     
  Branches     1187     1188    +1     
=======================================
+ Hits         5306     5307    +1     
  Misses       1829     1829           
  Partials      355      355           
Impacted Files Coverage Δ
jupyter_server/services/contents/filemanager.py 70.62% <100.00%> (ø)
...pyter_server/services/contents/largefilemanager.py 83.15% <100.00%> (+0.36%) ⬆️
jupyter_server/serverapp.py 65.38% <0.00%> (-0.13%) ⬇️
jupyter_server/extension/application.py 74.66% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 426a4c6...e6ca20f. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbrochart.

@Zsailer Zsailer merged commit 05baa15 into jupyter-server:main Mar 11, 2022
@davidbrochart davidbrochart deleted the fix_pre_save_hook branch March 11, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants