Implement Required Methods in Async Manner #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 70.92% 70.94% +0.02%
==========================================
Files 62 62
Lines 7490 7514 +24
Branches 1187 1190 +3
==========================================
+ Hits 5312 5331 +19
- Misses 1821 1826 +5
Partials 357 357
Continue to review full report at Codecov.
|
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AsyncFileContentsManagerwas missingasyncdefinitions of the a few required methods. Therefore because of the multiple inheritance, theFileContentsManagerdefinitions were being used resulting in an unpleasant developer experience when implementing a proxy Contents Manager responsible for delegating to anAsyncContentsManager(for our remote storage system at Twitter) or anAsyncLargeFileManager. This feels like undesired behavior to have a few CM methods need to be execute in a synchronous style and some in an async style usingawaitrequiring additional boilerplate type checking in my case.