Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up activity recording #722

Merged
merged 2 commits into from
Mar 13, 2022

Conversation

blink1073
Copy link
Collaborator

Avoid deserializing the entire message until we know it is a status message to avoid deserializing large iopub contents.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #722 (8abc494) into main (fb25932) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files          62       62           
  Lines        7502     7503    +1     
  Branches     1190     1190           
=======================================
+ Hits         5322     5323    +1     
  Misses       1823     1823           
  Partials      357      357           
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 82.59% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb25932...8abc494. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM Steve, thank you.

@blink1073 blink1073 merged commit 5d962d7 into jupyter-server:main Mar 13, 2022
@blink1073 blink1073 deleted the cleanup-serializing branch March 13, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants