Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI #723

Merged
merged 13 commits into from
Mar 14, 2022
Merged

Clean up CI #723

merged 13 commits into from
Mar 14, 2022

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Mar 13, 2022

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #723 (3e9d458) into main (fb25932) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   70.94%   70.87%   -0.07%     
==========================================
  Files          62       62              
  Lines        7502     7515      +13     
  Branches     1190     1190              
==========================================
+ Hits         5322     5326       +4     
- Misses       1823     1834      +11     
+ Partials      357      355       -2     
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 80.69% <0.00%> (-1.85%) ⬇️
jupyter_server/services/contents/filemanager.py 70.72% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb25932...3e9d458. Read the comment docs.

@blink1073 blink1073 changed the title Increase test timeout Clean up Ci Mar 13, 2022
@blink1073 blink1073 changed the title Clean up Ci Clean up CI Mar 13, 2022
@blink1073 blink1073 marked this pull request as draft March 13, 2022 16:29
@blink1073
Copy link
Collaborator Author

Drat, it looks like the nbclassic failure is legit.

@blink1073
Copy link
Collaborator Author

I opened jupyter/nbclassic#91, we'll need a release of that to be sure. I think the test timeouts are going to be blocked on jupyter/jupyter_client#751, so I don't think we should block this PR on that.

@blink1073 blink1073 marked this pull request as ready for review March 14, 2022 10:26
@blink1073
Copy link
Collaborator Author

Let's merge and iterate since this is already an improvement.

@blink1073 blink1073 merged commit c0dd949 into jupyter-server:main Mar 14, 2022
@blink1073 blink1073 deleted the increase-timeout branch March 14, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants