Remove 'coded redirect' to default_url #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Thanks! @Zsailer |
|
So redirecting from the base URL to the default URL has now become kind of mandatory. |
|
Yes. This is how the original notebook server worked, right? Anything that hit the base_url was redirected to |
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating #72, it was noticed that
--ServerApp.open_browser=True(the default) did not exhibit the bug. And the browser would open thedefault_urlas expected.This is because the
open_browserlogic effectively redirects to thedefault_urlin code.I propose changing the
open_browserlogic to simply open thebase_url, and allowing the redirect logic (if specified) to handling redirecting to thedefault_url. Rather than emulating this behavior in code.