Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise no-authorization warning once and allow disabled authorization #738

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Mar 15, 2022

Follow up on #717

Fixes #737

@Zsailer Zsailer changed the title raise warning once and allow disabled authorization raise no-authorization warning once and allow disabled authorization Mar 15, 2022
@Zsailer Zsailer added the bug label Mar 15, 2022
@Zsailer Zsailer self-assigned this Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #738 (2f3c592) into main (66ef12d) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   70.63%   70.56%   -0.07%     
==========================================
  Files          62       62              
  Lines        7610     7607       -3     
  Branches     1216     1215       -1     
==========================================
- Hits         5375     5368       -7     
- Misses       1867     1873       +6     
+ Partials      368      366       -2     
Impacted Files Coverage Δ
jupyter_server/auth/decorator.py 82.85% <75.00%> (+3.90%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 80.69% <0.00%> (-1.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ef12d...2f3c592. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Zsailer!

@blink1073 blink1073 merged commit a97edaa into jupyter-server:main Mar 16, 2022
@Zsailer Zsailer deleted the no-authorizer branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.15 series doesn't work with voila standalone server
4 participants