Call "/api/shutdown" instead of "/" #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 70.05% 69.97% -0.09%
==========================================
Files 63 63
Lines 7548 7557 +9
Branches 1258 1260 +2
==========================================
Hits 5288 5288
- Misses 1880 1889 +9
Partials 380 380
Continue to review full report at Codecov.
|
kevin-bates
reviewed
May 6, 2022
kevin-bates
previously approved these changes
May 6, 2022
|
One of the tests broke when calling with an arg like |
When running `jupyter lab stop` the wrong endpoint was being called
|
Ah - yes, the last commit makes sense (although I'm unfamiliar with the sockets usage), thank you for following up! |
kevin-bates
approved these changes
May 6, 2022
Zsailer
approved these changes
May 6, 2022
|
Thanks! |
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
May 6, 2022
Zsailer
added a commit
that referenced
this pull request
May 7, 2022
Co-authored-by: David Leen <dleen@netflix.com> Co-authored-by: Zachary Sailer <zsailer@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
jupyter lab stopthe wrong endpoint was being called