Allow subclasses to override default service handlers #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidartf
reviewed
Sep 10, 2019
Co-Authored-By: Vidar Tonaas Fauske <vidartf@gmail.com>
kevin-bates
reviewed
Sep 10, 2019
kevin-bates
reviewed
Sep 11, 2019
vidartf
reviewed
Sep 12, 2019
I don't have merge rights on this repo, so you can go ahead and do it after taking the small comment into account 😉 |
|
Ok, thanks @vidartf and @kevin-bates. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #80.
Previously, handlers were hardcoded into the server's web application. This PR allows subclasses to override what handlers are visible. This doesn't remove any services (i.e. the various managers in the server); rather, it allows subclasses to hide access to the services through their handlers.
@vidartf and @kevin-bates