Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hatch backend #846

Merged
merged 2 commits into from May 16, 2022
Merged

Use hatch backend #846

merged 2 commits into from May 16, 2022

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented May 16, 2022

Simplified version of #845 until we decided whether to adopt hatch_jupyter_builder, to get editable mode working again. cf pypa/pip#11110

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #846 (e37c681) into main (9bd9bdc) will decrease coverage by 1.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   70.04%   68.98%   -1.07%     
==========================================
  Files          63       63              
  Lines        7568     7309     -259     
  Branches     1262     1208      -54     
==========================================
- Hits         5301     5042     -259     
+ Misses       1888     1887       -1     
- Partials      379      380       +1     
Impacted Files Coverage Δ
jupyter_server/extension/handler.py 62.50% <0.00%> (-4.69%) ⬇️
jupyter_server/gateway/gateway_client.py 71.69% <0.00%> (-3.58%) ⬇️
jupyter_server/base/handlers.py 61.31% <0.00%> (-2.48%) ⬇️
jupyter_server/files/handlers.py 32.14% <0.00%> (-2.34%) ⬇️
jupyter_server/auth/login.py 68.93% <0.00%> (-1.99%) ⬇️
jupyter_server/services/shutdown.py 75.00% <0.00%> (-1.93%) ⬇️
jupyter_server/pytest_plugin.py 87.30% <0.00%> (-1.79%) ⬇️
jupyter_server/base/zmqhandlers.py 52.43% <0.00%> (-1.54%) ⬇️
jupyter_server/extension/application.py 71.69% <0.00%> (-1.40%) ⬇️
jupyter_server/serverapp.py 63.68% <0.00%> (-1.39%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd9bdc...e37c681. Read the comment docs.

@maartenbreddels
Copy link
Contributor

Hi,

interesting. Are there notes, or could you share the reasoning behind switching from flit to hatch?

cheers,

Maarten

@blink1073
Copy link
Collaborator Author

@blink1073
Copy link
Collaborator Author

Basically it gives us a lot more flexibility, including multiple top level entities, which is needed for ipykernel (to include ipykernel_launcher.py), cf ipython/ipykernel#931

@blink1073
Copy link
Collaborator Author

Help output test failures are due to #843, will focus on getting a traitlets release out now.

@blink1073 blink1073 closed this May 16, 2022
@blink1073 blink1073 reopened this May 16, 2022
@blink1073 blink1073 closed this May 16, 2022
@blink1073 blink1073 reopened this May 16, 2022
@blink1073 blink1073 merged commit a613459 into jupyter-server:main May 16, 2022
@blink1073 blink1073 deleted the use-pure-hatch branch May 16, 2022 13:25
@maartenbreddels
Copy link
Contributor

Thanks!
Always keeping an eye on what you are doing regarding CI etc, love it :)

@blink1073
Copy link
Collaborator Author

Always keeping an eye on what you are doing regarding CI etc, love it :)

Thank you! ❤️

Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants