Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for serverapp for reraise flag #887

Merged
merged 10 commits into from
Aug 29, 2022
Merged

Check for serverapp for reraise flag #887

merged 10 commits into from
Aug 29, 2022

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Jun 22, 2022

The secondary serverextension apps (enable/disable/list) should probably always complete even if an extension raises an error, so in those cases, default to just warning about exceptions, but still complete.

Fixes #676

Note: Not tested locally, just edited via GH interface. I'd prefer to add a regression test as well if I have time.

The supporting serverextension apps (enable/disable/list) should probably always complete even if an exception raises an error, so in those cases, default to just warning about exceptions, but still complete.
@blink1073 blink1073 added the bug label Jun 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #887 (f090a51) into main (6baed5e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   72.15%   72.12%   -0.03%     
==========================================
  Files          65       65              
  Lines        8044     8044              
  Branches     1343     1343              
==========================================
- Hits         5804     5802       -2     
- Misses       1835     1836       +1     
- Partials      405      406       +1     
Impacted Files Coverage Δ
jupyter_server/extension/manager.py 92.68% <100.00%> (ø)
jupyter_server/services/kernels/handlers.py 58.64% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Zsailer
Copy link
Member

Zsailer commented Aug 29, 2022

Thanks, @vidartf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'reraise_server_extension_failures'
4 participants