Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in IdentityProvider documentation #915

Merged
merged 1 commit into from Jul 29, 2022

Conversation

danielyahn
Copy link
Contributor

@danielyahn danielyahn commented Jul 11, 2022

Previous section has the following description

The first step is "Authentication" (identifying who is making the request). This is handled by the :class:.IdentityProvider.

I think it's more correct to say IdentityProvider class is responsible for the "authentication" step, instead of "authorization"

@welcome
Copy link

welcome bot commented Jul 11, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #915 (05ddb36) into main (3090893) will not change coverage.
The diff coverage is n/a.

❗ Current head 05ddb36 differs from pull request most recent head 6eca214. Consider uploading reports for the commit 6eca214 to get more accurate results

@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files          65       65           
  Lines        7983     7983           
  Branches     1334     1334           
=======================================
  Hits         5767     5767           
  Misses       1810     1810           
  Partials      406      406           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c22000...6eca214. Read the comment docs.

Zsailer
Zsailer previously approved these changes Jul 18, 2022
@vidartf vidartf merged commit e32f726 into jupyter-server:main Jul 29, 2022
@welcome
Copy link

welcome bot commented Jul 29, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@vidartf vidartf mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants