Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest_plugin with fixtures to test auth in core and extensions #956

Merged
merged 1 commit into from Aug 31, 2022

Conversation

akshaychitneni
Copy link
Contributor

Fixes #773

@welcome
Copy link

welcome bot commented Aug 30, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #956 (08663bb) into main (cc7e6c4) will increase coverage by 0.16%.
The diff coverage is 92.75%.

❗ Current head 08663bb differs from pull request most recent head 3550405. Consider uploading reports for the commit 3550405 to get more accurate results

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   72.07%   72.24%   +0.16%     
==========================================
  Files          64       64              
  Lines        8031     8098      +67     
  Branches     1340     1353      +13     
==========================================
+ Hits         5788     5850      +62     
- Misses       1837     1838       +1     
- Partials      406      410       +4     
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 89.23% <92.75%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

blink1073
blink1073 previously approved these changes Aug 31, 2022
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @akshaychitneni!

if fetch is jp_ws_fetch:
r.close()

print(code, url, fetch_kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed? 😉

Zsailer
Zsailer previously approved these changes Aug 31, 2022
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akshaychitneni! Just a minor comment inline. Otherwise this looks good!

@akshaychitneni
Copy link
Contributor Author

Thanks @akshaychitneni! Just a minor comment inline. Otherwise this looks good!

Thanks @Zsailer. Updated.

@blink1073 blink1073 merged commit 644540b into jupyter-server:main Aug 31, 2022
@welcome
Copy link

welcome bot commented Aug 31, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose some of the Auth test utility functions.
4 participants