Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server extension disable instructions #998

Merged
merged 1 commit into from Sep 27, 2022
Merged

Conversation

3coins
Copy link
Contributor

@3coins 3coins commented Sep 27, 2022

The current server extension disable instructions are incorrect, they are missing the keyword extension.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Base: 72.54% // Head: 72.54% // No change to project coverage 👍

Coverage data is based on head (2338055) compared to base (b8fe9d0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files          64       64           
  Lines        8243     8243           
  Branches     1378     1378           
=======================================
  Hits         5980     5980           
  Misses       1848     1848           
  Partials      415      415           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@3coins 3coins marked this pull request as ready for review September 27, 2022 15:53
@3coins 3coins requested a review from Zsailer September 27, 2022 15:54
Zsailer
Zsailer previously approved these changes Sep 27, 2022
The current server extension disable instructions are incorrect, they are missing the keyword `extension`.
@3coins
Copy link
Contributor Author

3coins commented Sep 27, 2022

@blink1073
What is missing here? Should I update this branch with Update with rebase button? I can also do a rebase locally and push again.

@blink1073
Copy link
Collaborator

Huh, I'm not sure why it shows that I dismissed the review. Merging, thanks!

@blink1073 blink1073 merged commit 017c52e into main Sep 27, 2022
@blink1073 blink1073 deleted the 3coins-patch-1 branch September 27, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants