Allow db_path to be set to ":memory:"

[cmd-ntrf]

Fix issue #69

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e668814) 85.49% compared to head (7d48519) 85.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   85.49%   85.84%   +0.34%     
==========================================
  Files           5        5              
  Lines         531      530       -1     
  Branches       68       67       -1     
==========================================
+ Hits          454      455       +1     
+ Misses         55       54       -1     
+ Partials       22       21       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Zsailer]

This is great, thank you @cmd-ntrf. Ideally, we have a unit test to cover this config option to make sure we don't accidentally remove it in the future.

Would you like to create such a unit test? Otherwise, I can take over this PR, write such a test, and merge.

[cmd-ntrf]

I have added a unit test. Let me know if there is anything else I can do.

[dlqqq]

@cmd-ntrf Thank you for this contribution! So sorry I let this one escape my review. In the future, please feel free to ping me directly for feedback.

I left a few suggestions for you below. The CI failure is actually coming from our linter system called pre-commit. After you address the feedback I've left below, you should run (in your dev environment):

pip install pre-commit
pre-commit run --all-files
git commit -am "pre-commit"
git push ...

[dlqqq]

Oh, forgot to mention: there actually is another CI failure not coming from pre-commit. I fixed this in #73, which I just merged. You'll want to rebase on main to include this so your CI passes:

git checkout main
git pull
# get back to this dev branch
git checkout -
git rebase main

# if the above command produced any errors, do not run the below command
git push -f

[cmd-ntrf]

I have rebased on main, applied the proposed changes and squashed into a single commit.

[Zsailer]

Thanks @cmd-ntrf!

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[Zsailer]

This change released today: https://github.com/jupyter-server/jupyter_server_fileid/releases/tag/v0.9.1

Thanks @cmd-ntrf!

[dlqqq]

@Zsailer Thanks for merging & releasing this PR while I was away for vacation! 🎉