Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable travis #15

Merged
merged 2 commits into from
Oct 14, 2015
Merged

Enable travis #15

merged 2 commits into from
Oct 14, 2015

Conversation

parente
Copy link
Contributor

@parente parente commented Oct 14, 2015

  • Add make install target
  • Only expose docker ports on dev, bash make targets

* Add make install target
* Only expose docker ports on dev, bash make targets

(c) Copyright IBM Corp. 2015
* Issues with capabilities and network

(c) Copyright IBM Corp. 2015
@parente parente changed the title [WIP] Enable travis Enable travis Oct 14, 2015
@parente
Copy link
Contributor Author

parente commented Oct 14, 2015

I went with non-containerized testing on Travis due to issues with Docker caps set on their infrastructure and then problems getting the tornado test runner to work. I originally traced the errors to tini so the details are over here krallin/tini#9 (comment)

At any rate, all the tests are passing now on Travis outside the container. And we get to test against multiple version of Python, not just the one in the container.

parente added a commit that referenced this pull request Oct 14, 2015
@parente parente merged commit af2e77e into jupyter-server:master Oct 14, 2015
@parente parente mentioned this pull request Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant