Merge pull request #2697 from jasongrout/linter

Fix lint errors
jupyter-widgets · Jan 8, 2020 · 1cdcb81 · 1cdcb81
2 parents 60c2d39 + d8d8b70
commit 1cdcb81
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 12 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -21,9 +21,8 @@ jobs:
         key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
         restore-keys: |
           ${{ runner.os }}-yarn-
-    - name: yarn install, build, integrity, test
+    - name: yarn install, integrity, lint
       run: |
         yarn install --frozen-lockfile
-        yarn run build
         yarn run integrity
         yarn run eslint:check
diff --git a/.github/workflows/testjs.yml b/.github/workflows/testjs.yml
@@ -29,7 +29,6 @@ jobs:
         yarn install --frozen-lockfile
         yarn run build
         yarn run build:examples
-        yarn run integrity
         
         pushd packages/base
         yarn run test:unit:firefox:headless

diff --git a/packages/base/src/widget.ts b/packages/base/src/widget.ts
@@ -886,8 +886,8 @@ class DOMWidgetView extends WidgetView {
         }
     }
 
-    updateTooltip() {
-        let title = this.model.get('tooltip')
+    updateTooltip(): void {
+        const title = this.model.get('tooltip')
         if (!title) {
             this.el.removeAttribute('title');
         } else if (this.model.get('description').length === 0) {

diff --git a/packages/controls/src/widget_bool.ts b/packages/controls/src/widget_bool.ts
@@ -120,9 +120,9 @@ class CheckboxView extends DescriptionView {
         }
     }
 
-    updateTooltip() {
+    updateTooltip(): void {
         if (!this.checkbox) return; // we might be constructing the parent
-        let title = this.model.get('tooltip');
+        const title = this.model.get('tooltip');
         if (!title) {
             this.checkbox.removeAttribute('title');
         } else if (this.model.get('description').length === 0) {

diff --git a/packages/controls/src/widget_description.ts b/packages/controls/src/widget_description.ts
@@ -77,7 +77,7 @@ class DescriptionView extends DOMWidgetView {
         }
     }
 
-    updateTooltip() {
+    updateTooltip(): void {
         if (!this.label) return;
         this.label.title = this.model.get('tooltip');
     }

diff --git a/packages/controls/src/widget_selection.ts b/packages/controls/src/widget_selection.ts
@@ -73,9 +73,9 @@ class SelectionView extends DescriptionView {
         }
     }
 
-    updateTooltip() {
+    updateTooltip(): void {
         if (!this.listbox) return; // we might be constructing the parent
-        let title = this.model.get('tooltip');
+        const title = this.model.get('tooltip');
         if (!title) {
             this.listbox.removeAttribute('title');
         } else if (this.model.get('description').length === 0) {

diff --git a/packages/controls/src/widget_string.ts b/packages/controls/src/widget_string.ts
@@ -39,7 +39,7 @@ class StringView extends DescriptionView {
     /**
      * Called when view is rendered.
      */
-   render() {
+   render(): void {
         super.render(); // Incl. setting some defaults.
         this.el.classList.add('jupyter-widgets');
         this.el.classList.add('widget-inline-hbox');
@@ -385,7 +385,7 @@ class TextView extends StringView {
         }
     }
 
-    updateTooltip() {
+    updateTooltip(): void {
         if (!this.textbox) return; // we might be constructing the parent
         const title = this.model.get('tooltip');
         if (!title) {