Skip to content

Commit

Permalink
Narrow typings for message callbacks
Browse files Browse the repository at this point in the history
There might have been a good reason why these weren't already narrowed, so should check.
  • Loading branch information
vidartf committed Aug 26, 2022
1 parent aa66afa commit 2085ee0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/base/src/services-shim.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import { Kernel, KernelMessage } from '@jupyterlab/services';
* Callbacks for services shim comms.
*/
export interface ICallbacks {
shell?: { [key: string]: (msg: KernelMessage.IMessage) => void };
iopub?: { [key: string]: (msg: KernelMessage.IMessage) => void };
input?: (msg: KernelMessage.IMessage) => void;
shell?: { [key: string]: (msg: KernelMessage.IShellMessage) => void };
iopub?: { [key: string]: (msg: KernelMessage.IIOPubMessage) => void };
input?: (msg: KernelMessage.IStdinMessage) => void;
}

export interface IClassicComm {
Expand Down

0 comments on commit 2085ee0

Please sign in to comment.